Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for PHP < 8.1 #162

Merged
merged 7 commits into from
Feb 24, 2024

Conversation

Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Jan 31, 2024

#153

drop PHPUnit 9 support.
replace php-http/guzzle6-adapter with php-http/guzzle7-adapter
bump dev dependencies
Migrate phpUnit config to version 10.
Improve some Tests

@Chris53897
Copy link
Contributor Author

@johanwilfer PR is ready for review. The Psalm errors should be handled in a seperate PR.

@johanwilfer johanwilfer linked an issue Feb 24, 2024 that may be closed by this pull request
@johanwilfer
Copy link
Collaborator

@Chris53897 Can you update https://github.com/TheBigBrainsCompany/TbbcMoneyBundle/blob/master/change-log-6.0-and-versions.md in this branch as well then and this is also good to be merge to master (for the upcomming 6.x version)?

@Chris53897
Copy link
Contributor Author

I have upgraded it. this can be finetuned before first tag of 6.x

@johanwilfer johanwilfer merged commit ef9d0d1 into TheBigBrainsCompany:master Feb 24, 2024
6 of 7 checks passed
@johanwilfer
Copy link
Collaborator

Great!

@Chris53897 Chris53897 deleted the feature/drop-php-8 branch February 24, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for PHP 8.0?
3 participants